[IMP] accounting: update the analytic budgets page #11330
Conversation
|
|
afma-odoo
force-pushed
the
18.0-accounting-analytic-budget-afma
branch
from
50c95f3 to
9b6025d
Compare
afma-odoo
force-pushed
the
18.0-accounting-analytic-budget-afma
branch
2 times, most recently
from
8c30b6d to
1a6648d
Compare
There was a problem hiding this comment.
Hey @afma-odoo :) Great update for this doc! I have a few comments - feel free to reach out in person tomorrow to look at any of them together or message any time if you have questions. Thanks for all your hard work here and sorry for the delay!
afma-odoo
force-pushed
the
18.0-accounting-analytic-budget-afma
branch
from
1a6648d to
9c7453e
Compare
|
@dade-odoo Thanks a lot for the review :) Definitely improves the explanations! |
afma-odoo
force-pushed
the
18.0-accounting-analytic-budget-afma
branch
from
9c7453e to
6bbbfd7
Compare
|
@dade-odoo Thanks a lot for your help ;) |
There was a problem hiding this comment.
Dear @afma-odoo, thank you for your work on this topic. I apologize in advance for my comments that are all over the place, I hope you can make sense of it all. (If not, feel free to reach out, and we can work through it together. 😅) Some general comments:
-
The phrasing “in the xxx status” felt a bit off to me, so I suggested removing the word status entirely (e.g., :guilabel:Open` budgets) or replacing it with with the xxx status. I hope I didn’t miss any, but just in case.
-
FYI, you can just include the app, file name, and anchor name in anchor names so it doesn't get super long (e.g., accounting/budget/analytic-budget) (but honestly it's not that bad here, so if you don't feel like changing them it's ok; just keep it in mind for next time)
-
I was not able to check that the images are compressed (trouble with PyCharm) so could you please double-check that?
PS: Thank you @dade-odoo for the first review 🙂
afma-odoo
force-pushed
the
18.0-accounting-analytic-budget-afma
branch
from
6bbbfd7 to
795fa5f
Compare
|
@auva-odoo Thanks for the review! Everything was clear to me ;) I confirm the images are compressed! |
afma-odoo
force-pushed
the
18.0-accounting-analytic-budget-afma
branch
from
795fa5f to
47f147c
Compare
There was a problem hiding this comment.
Hi @afma-odoo thank you for the changes! I just have one tiny comment so I'll go ahead and approve this already (I would have pushed the change myself but I still have that issue I was talking about the other day 🥺 ). You can r+ when you're ready and all checks have passed 🙂
@robodoo delegate+
|
|
||
| To reveal the :guilabel:`Theoretical` amount or percentage, use the :icon:`oi-settings-adjust` | ||
| (:guilabel:`adjust settings`) icon in the :guilabel:`Budget Lines`' header. The | ||
| :guilabel:`Theoretical` represents the amount of money that could theoretically have been spent or |
There was a problem hiding this comment.
| :guilabel:`Theoretical` represents the amount of money that could theoretically have been spent or | |
| :guilabel:`Theoretical` amount represents the amount of money that could theoretically have been spent or |
or column? but I feel like something's missing
task-4237563 task-4257623 task-4308176 task-4369415
afma-odoo
force-pushed
the
18.0-accounting-analytic-budget-afma
branch
from
47f147c to
378f878
Compare
|
@auva-odoo You're right, thanks! @robodoo r+ |
task-4237563 task-4257623 task-4308176 task-4369415 closes #11330 Signed-off-by: Anne-Françoise Marcq (afma) <afma@odoo.com>
task-4237563
task-4257623
task-4308176
task-4369415